Revision: 23397
Author: [email protected]
Date: Tue Aug 26 11:34:25 2014 UTC
Log: Fixed inlining of constant values
Use CopyToRepresentation to elide HForceRepresentation of HConstant
BUG=v8:3529
LOG=y
[email protected]
Review URL: https://codereview.chromium.org/507613002
https://code.google.com/p/v8/source/detail?r=23397
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-force-constant-representation.js
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.cc
/branches/bleeding_edge/src/property-details-inl.h
/branches/bleeding_edge/src/property-details.h
=======================================
--- /dev/null
+++
/branches/bleeding_edge/test/mjsunit/regress/regress-force-constant-representation.js
Tue Aug 26 11:34:25 2014 UTC
@@ -0,0 +1,18 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+// Test push double as tagged.
+var a = [{}];
+function f(a) {
+ a.push(Infinity);
+}
+
+f(a);
+f(a);
+f(a);
+%OptimizeFunctionOnNextCall(f);
+f(a);
+assertEquals([{}, Infinity, Infinity, Infinity, Infinity], a);
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Thu Aug 21
09:34:47 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Tue Aug 26
11:34:25 2014 UTC
@@ -1512,17 +1512,8 @@
HValue* value, Representation representation) {
if (FLAG_fold_constants && value->IsConstant()) {
HConstant* c = HConstant::cast(value);
- if (c->HasNumberValue()) {
- double double_res = c->DoubleValue();
- if (representation.IsDouble()) {
- return HConstant::New(zone, context, double_res);
-
- } else if (representation.CanContainDouble(double_res)) {
- return HConstant::New(zone, context,
- static_cast<int32_t>(double_res),
- representation);
- }
- }
+ c = c->CopyToRepresentation(representation, zone);
+ if (c != NULL) return c;
}
return new(zone) HForceRepresentation(value, representation);
}
=======================================
--- /branches/bleeding_edge/src/property-details-inl.h Tue Jun 3 08:12:43
2014 UTC
+++ /branches/bleeding_edge/src/property-details-inl.h Tue Aug 26 11:34:25
2014 UTC
@@ -13,18 +13,6 @@
namespace v8 {
namespace internal {
-inline bool Representation::CanContainDouble(double value) {
- if (IsDouble() || is_more_general_than(Representation::Double())) {
- return true;
- }
- if (IsInt32Double(value)) {
- if (IsInteger32()) return true;
- if (IsSmi()) return Smi::IsValid(static_cast<int32_t>(value));
- }
- return false;
-}
-
-
Representation Representation::FromType(Type* type) {
DisallowHeapAllocation no_allocation;
if (type->Is(Type::None())) return Representation::None();
=======================================
--- /branches/bleeding_edge/src/property-details.h Thu Aug 21 09:34:47 2014
UTC
+++ /branches/bleeding_edge/src/property-details.h Tue Aug 26 11:34:25 2014
UTC
@@ -121,8 +121,6 @@
bool fits_into(const Representation& other) const {
return other.is_more_general_than(*this) || other.Equals(*this);
}
-
- bool CanContainDouble(double value);
Representation generalize(Representation other) {
if (other.fits_into(*this)) return *this;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
