Reviewers: Yang,
Message:
PTAL
Description:
Delete unused DescriptorArray::Append with whitenesswitness
BUG=
Please review this at https://codereview.chromium.org/501363002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -23 lines):
M src/objects.h
M src/objects-inl.h
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index
9289900675cf1cb89a4457e1f5a9dfe2b145fefb..33000b668eb0b7012913c3bb296666b0c52ff2e6
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -3052,27 +3052,6 @@ void DescriptorArray::Set(int descriptor_number,
Descriptor* desc) {
}
-void DescriptorArray::Append(Descriptor* desc,
- const WhitenessWitness& witness) {
- DisallowHeapAllocation no_gc;
- int descriptor_number = number_of_descriptors();
- SetNumberOfDescriptors(descriptor_number + 1);
- Set(descriptor_number, desc, witness);
-
- uint32_t hash = desc->GetKey()->Hash();
-
- int insertion;
-
- for (insertion = descriptor_number; insertion > 0; --insertion) {
- Name* key = GetSortedKey(insertion - 1);
- if (key->Hash() <= hash) break;
- SetSortedKey(insertion, GetSortedKeyIndex(insertion - 1));
- }
-
- SetSortedKey(insertion, descriptor_number);
-}
-
-
void DescriptorArray::Append(Descriptor* desc) {
DisallowHeapAllocation no_gc;
int descriptor_number = number_of_descriptors();
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
4ba4c95f42f43b6c095445bb76582acb16147bdc..9fa6bd791747cccbeffb000223a9ab4c42386ce3
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -3484,8 +3484,6 @@ class DescriptorArray: public FixedArray {
Descriptor* desc,
const WhitenessWitness&);
- inline void Append(Descriptor* desc, const WhitenessWitness&);
-
// Swap first and second descriptor.
inline void SwapSortedKeys(int first, int second);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
