lgtm
(I don't have much to say on the substance on the change, though. gyp+GN
looks
fine.)
https://codereview.chromium.org/508673002/diff/40001/src/ic/mips/ic-conventions-mips.cc
File src/ic/mips/ic-conventions-mips.cc (right):
https://codereview.chromium.org/508673002/diff/40001/src/ic/mips/ic-conventions-mips.cc#newcode35
src/ic/mips/ic-conventions-mips.cc:35:
nitpick: why the empty lines? (also in ../mips64/.. version)
https://codereview.chromium.org/508673002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
