Reviewers: Sven Panne,
Description:
Slightly simplify Math.sign and Math.trunc.
[email protected]
Please review this at https://codereview.chromium.org/504343005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -4 lines):
M src/math.js
Index: src/math.js
diff --git a/src/math.js b/src/math.js
index
00a507a28e5514d0ebdfcb81acc194821e443a98..7ead7a861efe20c82dcb70c736ee1ee82305bc21
100644
--- a/src/math.js
+++ b/src/math.js
@@ -173,8 +173,8 @@ function MathSign(x) {
x = TO_NUMBER_INLINE(x);
if (x > 0) return 1;
if (x < 0) return -1;
- if (x === 0) return x;
- return NAN;
+ // -0, 0 or NaN.
+ return x;
}
// ES6 draft 09-27-13, section 20.2.2.34.
@@ -182,8 +182,8 @@ function MathTrunc(x) {
x = TO_NUMBER_INLINE(x);
if (x > 0) return MathFloor(x);
if (x < 0) return MathCeil(x);
- if (x === 0) return x;
- return NAN;
+ // -0, 0 or NaN.
+ return x;
}
// ES6 draft 09-27-13, section 20.2.2.30.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
