LGTM with nits
https://codereview.chromium.org/505133002/diff/140001/test/compiler-unittests/instruction-selector-unittest.cc
File test/compiler-unittests/instruction-selector-unittest.cc (right):
https://codereview.chromium.org/505133002/diff/140001/test/compiler-unittests/instruction-selector-unittest.cc#newcode405
test/compiler-unittests/instruction-selector-unittest.cc:405: Stream s =
m.Build(kAllWithoutNopInstructions);
Nit: Please rename to kAllExceptNopInstructions
https://codereview.chromium.org/505133002/diff/140001/test/compiler-unittests/instruction-selector-unittest.cc#newcode468
test/compiler-unittests/instruction-selector-unittest.cc:468: }
Nit: missing blank line for cpplint happiness.
https://codereview.chromium.org/505133002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
