On 2014/08/26 11:43:23, Ryan T. (EMEA time) wrote:
lgtm

add bug #?

Hmm, didn't create one for the git-transition clean-ups. I guess this is the
last one out of 5...


https://codereview.chromium.org/504443005/diff/1/tools/push-to-trunk/chromium_roll.py
File tools/push-to-trunk/chromium_roll.py (right):


https://codereview.chromium.org/504443005/diff/1/tools/push-to-trunk/chromium_roll.py#newcode1
tools/push-to-trunk/chromium_roll.py:1: #!/usr/bin/env python
I feel like this file can be easily rewritten as a recipe.  And you'd get
extra
things for free, like expectations and automatic buildbot runnability

I thought about that. We can talk offline.

https://codereview.chromium.org/504443005/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to