Reviewers: Yang,
Message:
PTAL
Description:
Remove false checks since GetOwnProperty now throws an exception on access
check
violation.
BUG=
Please review this at https://codereview.chromium.org/514613002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -12 lines):
M src/v8natives.js
Index: src/v8natives.js
diff --git a/src/v8natives.js b/src/v8natives.js
index
00d8a88d7342222a04357665c0b4ae9f11c0501b..a522738b881b9042f4a3cc0a44e3ec76e022229e
100644
--- a/src/v8natives.js
+++ b/src/v8natives.js
@@ -571,10 +571,6 @@ SetUpLockedPrototype(PropertyDescriptor, $Array(
// property descriptor. For a description of the array layout please
// see the runtime.cc file.
function ConvertDescriptorArrayToDescriptor(desc_array) {
- if (desc_array === false) {
- throw 'Internal error: invalid desc_array';
- }
-
if (IS_UNDEFINED(desc_array)) {
return UNDEFINED;
}
@@ -649,9 +645,6 @@ function GetOwnPropertyJS(obj, v) {
// If p is not a property on obj undefined is returned.
var props = %GetOwnProperty(ToObject(obj), p);
- // A false value here means that access checks failed.
- if (props === false) return UNDEFINED;
-
return ConvertDescriptorArrayToDescriptor(props);
}
@@ -692,11 +685,8 @@ function DefineProxyProperty(obj, p, attributes,
should_throw) {
// ES5 8.12.9.
function DefineObjectProperty(obj, p, desc, should_throw) {
- var current_or_access = %GetOwnProperty(ToObject(obj), ToName(p));
- // A false value here means that access checks failed.
- if (current_or_access === false) return UNDEFINED;
-
- var current = ConvertDescriptorArrayToDescriptor(current_or_access);
+ var current_array = %GetOwnProperty(ToObject(obj), ToName(p));
+ var current = ConvertDescriptorArrayToDescriptor(current_array);
var extensible = %IsExtensible(ToObject(obj));
// Error handling according to spec.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
