LGTM with a nit
https://codereview.chromium.org/510773002/diff/60001/src/base/flags.h
File src/base/flags.h (right):
https://codereview.chromium.org/510773002/diff/60001/src/base/flags.h#newcode30
src/base/flags.h:30: Flags(const Flags& flags) : mask_(flags.mask_) {}
Do we really need an explicit copy constructor and assignment operator?
They are equivalent to the auto-generated ones.
https://codereview.chromium.org/510773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
