LGTM with nits.
https://codereview.chromium.org/514643002/diff/1/src/compiler/arm64/code-generator-arm64.cc
File src/compiler/arm64/code-generator-arm64.cc (left):
https://codereview.chromium.org/514643002/diff/1/src/compiler/arm64/code-generator-arm64.cc#oldcode150
src/compiler/arm64/code-generator-arm64.cc:150:
AddNopForSmiCodeInlining();
Yeah! You are my hero. :)
https://codereview.chromium.org/514643002/diff/1/src/compiler/js-generic-lowering.cc
File src/compiler/js-generic-lowering.cc (right):
https://codereview.chromium.org/514643002/diff/1/src/compiler/js-generic-lowering.cc#newcode224
src/compiler/js-generic-lowering.cc:224: ReplaceWithStubCall(node,
&stub, CallDescriptor::kPatchableCallSite | \
nit: Can we use the kPatchableCallSiteWithNop shorthand here?
https://codereview.chromium.org/514643002/diff/1/src/compiler/linkage.h
File src/compiler/linkage.h (left):
https://codereview.chromium.org/514643002/diff/1/src/compiler/linkage.h#oldcode46
src/compiler/linkage.h:46: // TODO(jarin) kLazyDeoptimization and
kNeedsFrameState should be unified.
nit: I think the TODO for Jaro still applies, better double-check with
him before removing it.
https://codereview.chromium.org/514643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
