LGTM with nit.
https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-changes-lowering.cc
File test/cctest/compiler/test-changes-lowering.cc (right):
https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-changes-lowering.cc#newcode310
test/cctest/compiler/test-changes-lowering.cc:310:
TEST(RunChangeInt32ToTagged_smi) {
nit: s/_smi/Smi/
https://codereview.chromium.org/512753002/diff/1/test/cctest/compiler/test-changes-lowering.cc#newcode327
test/cctest/compiler/test-changes-lowering.cc:327:
TEST(RunChangeUint32ToTagged_smi) {
nit: s/_smi/Smi/
https://codereview.chromium.org/512753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
