On 2014/08/28 11:14:04, balazs.kilvady wrote:
On 2014/08/28 10:50:17, Yang wrote:
> On 2014/08/28 10:47:08, rmcilroy wrote:
> > On 2014/08/28 10:38:15, Yang wrote:
> > > On 2014/08/28 09:54:43, balazs.kilvady wrote:
> > > > On 2014/08/28 09:48:54, Yang wrote:
> > > > > On 2014/08/28 09:45:19, balazs.kilvady wrote:
> > > > > > PTAL. Could a v8 team member review?
> > > > >
> > > > > Why is it necessary for MIPS? Would the same also apply for ARM?
> > > > Thank you for the quick review.
> > > >
> > > > The same has done for arm/V8_OOL_CONSTANT_POOL arches in r
r23242. Wee
> need
> > > this
> > > > change to fix failing mjsunit/deserialize-reference tests. To fix
that
> test
> > we
> > > > need serialize root_ objects by their root index and deserialize
them
with
> a
> > > > CASE_STATEMENT(kRootArray, kFromCode, kStartOfObject, 0) case
branch.
> > >
> > > I was just wondering whether it's better to just set
V8_OOL_CONSTANT_POOL
> for
> > > MIPS platforms.
> >
> > There is no ool constant pool support for MIPS yet AFAIK.
>
> Hm... I don't think I understand the problem here.
>
> The fix r23242 was for OOL constant pool on ARM. If MIPS doesn't have
that,
why
> does it need thses case statements? Is there anything on MIPS regarding
> referencing objects in the root array from code, that's different than
all
other
> platforms?
We don't have a no ool constant pool support for MIPS. And
nothing special for MIPS. With this patch we wold like to remove the
special
handling
for MIPS, the code block in serialize.cc at line 1305. If that block is
removed
then
objects of root_ are serialized by their index and without removing that
block
root
objects are serialized as copies of general objects.
But if we remove that block then we also need a
CASE_STATEMENT(kRootArray, kFromCode, kStartOfObject, 0)
CASE_BODY(kRootArray, kFromCode, kStartOfObject, 0)
case branch at deserialization (to deserialize root object references
(from
code) by
their root index like on ARM).
alright. lgtm.
https://codereview.chromium.org/492303004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
