Revision: 23487
Author: [email protected]
Date: Thu Aug 28 11:27:21 2014 UTC
Log: MIPS: Fix [de]serialize problem of root objects.
BUG
TEST=mjsunit/deserialize-reference
[email protected]
Review URL: https://codereview.chromium.org/492303004
https://code.google.com/p/v8/source/detail?r=23487
Modified:
/branches/bleeding_edge/src/serialize.cc
/branches/bleeding_edge/test/mjsunit/mjsunit.status
=======================================
--- /branches/bleeding_edge/src/serialize.cc Thu Aug 28 10:51:43 2014 UTC
+++ /branches/bleeding_edge/src/serialize.cc Thu Aug 28 11:27:21 2014 UTC
@@ -1087,7 +1087,8 @@
// current object.
CASE_STATEMENT(kRootArray, kPlain, kStartOfObject, 0)
CASE_BODY(kRootArray, kPlain, kStartOfObject, 0)
-#if V8_OOL_CONSTANT_POOL
+#if defined(V8_TARGET_ARCH_MIPS) || V8_OOL_CONSTANT_POOL || \
+ defined(V8_TARGET_ARCH_MIPS64)
// Find an object in the roots array and write a pointer to it to in
code.
CASE_STATEMENT(kRootArray, kFromCode, kStartOfObject, 0)
CASE_BODY(kRootArray, kFromCode, kStartOfObject, 0)
@@ -1302,14 +1303,6 @@
for (int i = 0; i < root_index_wave_front_; i++) {
Object* root = heap->roots_array_start()[i];
if (!root->IsSmi() && root == heap_object) {
-#if defined(V8_TARGET_ARCH_MIPS) || defined(V8_TARGET_ARCH_MIPS64)
- if (from == kFromCode) {
- // In order to avoid code bloat in the deserializer we don't have
- // support for the encoding that specifies a particular root should
- // be written from within code.
- return kInvalidRootIndex;
- }
-#endif
return i;
}
}
=======================================
--- /branches/bleeding_edge/test/mjsunit/mjsunit.status Tue Aug 26 16:42:09
2014 UTC
+++ /branches/bleeding_edge/test/mjsunit/mjsunit.status Thu Aug 28 11:27:21
2014 UTC
@@ -466,9 +466,6 @@
# Currently always deopt on minus zero
'math-floor-of-div-minus-zero': [SKIP],
-
- # BUG(v8:3457).
- 'deserialize-reference': [SKIP],
}], # 'arch == mipsel or arch == mips'
##############################################################################
@@ -520,9 +517,6 @@
# Currently always deopt on minus zero
'math-floor-of-div-minus-zero': [SKIP],
-
- # BUG(v8:3457).
- 'deserialize-reference': [SKIP],
}], # 'arch == mips64el'
['arch == mips64el and simulator_run == False', {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
