On 2014/08/28 11:54:03, Slava Chigrin wrote:
On 2014/08/28 11:45:29, Yang wrote:
> Committed patchset #1 (id:1) manually as 23488 (presubmit successful).
Thank you so much for help! I have one little question about serializer:
why
it
have so big macro CASE_BODY in Deserializer::ReadChunk? May be using
inline
templatized function instead of it can improve readability and have better
stack
space usage (due to local variables re-using). It may be important since
that
function called recursively, so it may not work well on large heaps...
Not sure. If I'm not mistaken, it was an effort to improve performance. I
think
the compiler should eliminate the unnecessary if-blocks as dead code, so it
probably doesn't make too much of a difference?
https://codereview.chromium.org/510013002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
