Reviewers: vogelheim,
Message:
Some platforms just don't take kindly to positional arguments in format
strings.
Description:
Fix test failures after r23492.
[email protected]
TEST=cctest/test-run-properties/TypedArrayLoad
Please review this at https://codereview.chromium.org/517673002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -8 lines):
M test/cctest/cctest.status
M test/cctest/compiler/test-run-properties.cc
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
fea4b3bf8e3f0589dcc6325fc895b4b8ed0d80c8..f2bb922c4f3c8cfecc3266fdcb349881c7ad266a
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -255,9 +255,6 @@
# BUG(v8:3433). Crashes on windows.
'test-cpu-profiler/FunctionApplySample': [SKIP],
- # TODO(mstarzinger): Investigate and fix.
- 'test-run-properties/TypedArrayLoad': [SKIP],
-
}], # 'system == windows'
##############################################################################
Index: test/cctest/compiler/test-run-properties.cc
diff --git a/test/cctest/compiler/test-run-properties.cc
b/test/cctest/compiler/test-run-properties.cc
index
c6d8dc8ed66a4d650fce3e6e5b156ecb9dd15f53..72816da9bcf22fad68606585fd6d7274c40f9568
100644
--- a/test/cctest/compiler/test-run-properties.cc
+++ b/test/cctest/compiler/test-run-properties.cc
@@ -29,10 +29,10 @@ static void TypedArrayLoadHelper(const char*
array_type) {
// - IsExternalArrayElementsKind(y)
const char* source =
"(function(a) {"
- " var x = (a = new %1$sArray(%2$d)); %3$s;"
- " var y = (a =
new %1$sArray(%2$d)); %3$s; %%TypedArrayGetBuffer(y);"
- " if (!%%HasFixed%1$sElements(x)) %%AbortJS('x');"
- " if (!%%HasExternal%1$sElements(y)) %%AbortJS('y');"
+ " var x = (a = new %sArray(%d)); %s;"
+ " var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);"
+ " if (!%%HasFixed%sElements(x)) %%AbortJS('x');"
+ " if (!%%HasExternal%sElements(y)) %%AbortJS('y');"
" function f(a,b) {"
" a = a | 0; b = b | 0;"
" return x[a] + y[b];"
@@ -40,7 +40,8 @@ static void TypedArrayLoadHelper(const char* array_type) {
" return f;"
"})()";
EmbeddedVector<char, 1024> source_buffer;
- SNPrintF(source_buffer, source, array_type, size, values_buffer.start());
+ SNPrintF(source_buffer, source, array_type, size, values_buffer.start(),
+ array_type, size, values_buffer.start(), array_type,
array_type);
FunctionTester T(
source_buffer.start(),
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
