Revision: 23498
Author: [email protected]
Date: Thu Aug 28 17:28:57 2014 UTC
Log: Fix test failures after r23492.
[email protected]
TEST=cctest/test-run-properties/TypedArrayLoad
Review URL: https://codereview.chromium.org/517673002
https://code.google.com/p/v8/source/detail?r=23498
Modified:
/branches/bleeding_edge/test/cctest/cctest.status
/branches/bleeding_edge/test/cctest/compiler/test-run-properties.cc
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Thu Aug 28 15:19:05
2014 UTC
+++ /branches/bleeding_edge/test/cctest/cctest.status Thu Aug 28 17:28:57
2014 UTC
@@ -255,9 +255,6 @@
# BUG(v8:3433). Crashes on windows.
'test-cpu-profiler/FunctionApplySample': [SKIP],
- # TODO(mstarzinger): Investigate and fix.
- 'test-run-properties/TypedArrayLoad': [SKIP],
-
}], # 'system == windows'
##############################################################################
=======================================
--- /branches/bleeding_edge/test/cctest/compiler/test-run-properties.cc Thu
Aug 28 14:35:11 2014 UTC
+++ /branches/bleeding_edge/test/cctest/compiler/test-run-properties.cc Thu
Aug 28 17:28:57 2014 UTC
@@ -29,10 +29,10 @@
// - IsExternalArrayElementsKind(y)
const char* source =
"(function(a) {"
- " var x = (a = new %1$sArray(%2$d)); %3$s;"
- " var y = (a =
new %1$sArray(%2$d)); %3$s; %%TypedArrayGetBuffer(y);"
- " if (!%%HasFixed%1$sElements(x)) %%AbortJS('x');"
- " if (!%%HasExternal%1$sElements(y)) %%AbortJS('y');"
+ " var x = (a = new %sArray(%d)); %s;"
+ " var y = (a = new %sArray(%d)); %s; %%TypedArrayGetBuffer(y);"
+ " if (!%%HasFixed%sElements(x)) %%AbortJS('x');"
+ " if (!%%HasExternal%sElements(y)) %%AbortJS('y');"
" function f(a,b) {"
" a = a | 0; b = b | 0;"
" return x[a] + y[b];"
@@ -40,7 +40,8 @@
" return f;"
"})()";
EmbeddedVector<char, 1024> source_buffer;
- SNPrintF(source_buffer, source, array_type, size, values_buffer.start());
+ SNPrintF(source_buffer, source, array_type, size, values_buffer.start(),
+ array_type, size, values_buffer.start(), array_type,
array_type);
FunctionTester T(
source_buffer.start(),
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
