On 2014/08/28 17:15:55, Raymond Toy wrote:
lgtm for the code.
For the tests, I disagree on running the tests with --no-fast-math since
that's
not how V8 is normally run, right?
But I won't block this CL for that.
https://codereview.chromium.org/488003005/diff/40001/test/mjsunit/es6/math-hyperbolic.js
File test/mjsunit/es6/math-hyperbolic.js (right):
https://codereview.chromium.org/488003005/diff/40001/test/mjsunit/es6/math-hyperbolic.js#newcode105
test/mjsunit/es6/math-hyperbolic.js:105:
assertEqualsDelta(-74.203210577788,
Math.sinh(-5), 1E-12);
Are these two sinh tests needed now?
Perhaps you can replace them with the exact fdlibm value of
74.20321057778875.
https://codereview.chromium.org/488003005/diff/40001/test/mjsunit/es6/math-hyperbolic.js#newcode162
test/mjsunit/es6/math-hyperbolic.js:162:
assertEquals(-1.7976931348621744e308,
Math.sinh(-710.4758600739439));
On 2014/08/28 07:18:08, Yang wrote:
> On 2014/08/27 16:22:02, Raymond Toy wrote:
> > Do the tests in lines 155-162 actually pass? They do not for me
because
> Math.exp
> > is inaccurate for these values.
>
> They do, with --no-fast-math we use the slow library implementation for
exp.
If this is how you normally run these tests, then ok. Otherwise, I think
this
is
a bad idea since chrome doesn't normally use --no-fast-math, right?
https://codereview.chromium.org/488003005/diff/40001/third_party/fdlibm/fdlibm.js
File third_party/fdlibm/fdlibm.js (right):
https://codereview.chromium.org/488003005/diff/40001/third_party/fdlibm/fdlibm.js#newcode733
third_party/fdlibm/fdlibm.js:733: const KSINH_OVERFLOW = kMath[52];
On 2014/08/28 07:18:08, Yang wrote:
> On 2014/08/27 16:22:02, Raymond Toy wrote:
> > Why is KSINH_OVERFLOW an element of kMath, but TWO_M28 and LOG_MAXD
are
not?
> >
> > This is ok, but I'm curious why these constants are treated
differently.
>
> TWO_M28 and LOG_MAXD have empty lower halves, so the machine code
emitted
for
> those constants is good enough so that we don't need to load it from a
constant
> pool.
Ok.
I'll add a TODO to implement a new exp.
https://codereview.chromium.org/488003005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
