https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp#newcode281
tools/gyp/v8.gyp:281: '<(PRODUCT_DIR)/snapshot_blob_host.bin',
On 2014/08/29 14:10:55, vogelheim wrote:
I'm a bit skeptical here: snapshot.cc and snapshot_blob.bin represent
largely
the same data, but in a different format: One as constants in C, the
other as a
blob file. So if we disambiguate between the host and target blob
file, we would
probably also disambiguate the equivalent .cc file.
Admittedly this is more pattern matching than a specific problem this
might
cause, but... well.
I think the difference is that snapshot.cc is already disambiguated
between host / target because it is in <(INTERMEDIATE_DIR) (which is
different for host and target), whereas <(PRODUCT_DIR) is the same for
both the host / target builds and so has to be explicitly
differentiated.
https://codereview.chromium.org/506983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
