When you reland, could you consider the comment in base.gyp:68?
Thanks for moving this target out of v8.gyp.
https://codereview.chromium.org/518023002/diff/1/src/base/base.gyp
File src/base/base.gyp (right):
https://codereview.chromium.org/518023002/diff/1/src/base/base.gyp#newcode17
src/base/base.gyp:17: 'include_dirs+': [
include_dirs+? I don't recall seem this on Chromium.
https://codereview.chromium.org/518023002/diff/1/src/base/base.gyp#newcode68
src/base/base.gyp:68: 'link_settings': {
I think you should keep indenting two spaces here as well (not four).
https://codereview.chromium.org/518023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
