Reviewers: Erik Corry, Description: Change cache test to only test for correct behavior on collisions and not the exact value.
On MacOS, there is a difference in the last decimal digit from the other platforms. [email protected] Please review this at http://codereview.chromium.org/180062 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/mjsunit/transcendentals.js Index: test/mjsunit/transcendentals.js =================================================================== --- test/mjsunit/transcendentals.js (revision 2798) +++ test/mjsunit/transcendentals.js (working copy) @@ -31,26 +31,19 @@ var x = 0x123456789ABCD / 0x2000000000000; var y = 0x1134567899BCD / 0x2000000000000; -assertEquals(0.5386962702923196, Math.sin(x)); -assertEquals(0.5121094149171027, Math.sin(y)); +assertTrue(Math.sin(x) != Math.sin(y)); -assertEquals(0.8425000465122504, Math.cos(x)); -assertEquals(0.8589202216464942, Math.cos(y)); +assertTrue(Math.cos(x) != Math.cos(y)); -assertEquals(0.6394020659374369, Math.tan(x)); -assertEquals(0.5962246574372441, Math.tan(y)); +assertTrue(Math.tan(x) != Math.tan(y)); -assertEquals(-0.5640701382848059, Math.log(x)); -assertEquals(-0.6205681544400349, Math.log(y)); +assertTrue(Math.log(x) != Math.log(y)); -assertEquals(0.6051541873165459, Math.asin(x)); -assertEquals(0.5676343396849298, Math.asin(y)); +assertTrue(Math.asin(x) != Math.asin(y)); -assertEquals(0.9656421394783508, Math.acos(x)); -assertEquals(1.0031619871099668, Math.acos(y)); +assertTrue(Math.acos(x) != Math.acos(y)); -assertEquals(0.5172294898564562, Math.atan(x)); -assertEquals(0.4933034078249788, Math.atan(y)); +assertTrue(Math.atan(x) != Math.atan(y)); -assertEquals(1.7663034013841883, Math.exp(x)); -assertEquals(1.7119599587777090, Math.exp(y)); +assertTrue(Math.exp(x) != Math.exp(y)); + --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
