lgtm.
https://codereview.chromium.org/527603002/diff/40001/src/compiler/change-lowering.cc
File src/compiler/change-lowering.cc (right):
https://codereview.chromium.org/527603002/diff/40001/src/compiler/change-lowering.cc#newcode54
src/compiler/change-lowering.cc:54: machine()->is32() ?
static_cast<int>(SmiTagging<4>::kSmiValueSize)
You might want to define a static method GetSmiValueSize() in
SmiTagging<> to encapsulate of the ugly cast (and possibly get rid of
the enum).
https://codereview.chromium.org/527603002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
