I just started to look a little bit into the reviewable parts, see the
individual comments below. Instead of fixing these in this CL, I propose to
split up the CL into manageable parts as follows:
* The first CL should just contain fixes for big-endian support in the
current v8, no PowerPC stuff yet. We really need to keep architecture and
endianess separate here!
* A CL with src/ppc only, no other changes. This will hopefully make our
tooling happy and the v8 team doesn't need to review this.
* A CL hooking in the PowerPC part.
https://codereview.chromium.org/422063005/diff/70001/Makefile
File Makefile (right):
https://codereview.chromium.org/422063005/diff/70001/Makefile#newcode204
Makefile:204: GYPFLAGS += -Dv8_host_byteorder=$(shell python -c "import
sys; print sys.byteorder")
Why???
https://codereview.chromium.org/422063005/diff/70001/src/base/platform/platform-posix.cc
File src/base/platform/platform-posix.cc (right):
https://codereview.chromium.org/422063005/diff/70001/src/base/platform/platform-posix.cc#newcode151
src/base/platform/platform-posix.cc:151: #elif V8_TARGET_ARCH_PPC
No need for a separate case here, just extend the comment in the default
below.
https://codereview.chromium.org/422063005/diff/70001/src/base/platform/platform-posix.cc#newcode244
src/base/platform/platform-posix.cc:244: #if V8_TARGET_ARCH_PPC_BE
Please don't mix up the architecture and the endianess, we have separate
#defines for the latter: V8_TARGET_BIG_ENDIAN and
V8_TARGET_LITTLE_ENDIAN, these should be orthogonal to
V8_TARGET_ARCH_PPC{,64}.
https://codereview.chromium.org/422063005/diff/70001/src/base/platform/platform-posix.cc#newcode619
src/base/platform/platform-posix.cc:619: #if V8_TARGET_ARCH_PPC
Huh? How is this related to the *architecture*? Do we have a POSIX
platform without sched_yield? Sounds a bit strange...
https://codereview.chromium.org/422063005/diff/70001/src/disassembler.cc
File src/disassembler.cc (right):
https://codereview.chromium.org/422063005/diff/70001/src/disassembler.cc#newcode110
src/disassembler.cc:110: #if !V8_TARGET_ARCH_PPC
No architecture-dependent #ifdefs in this file, please.
https://codereview.chromium.org/422063005/diff/70001/src/hydrogen-bch.cc
File src/hydrogen-bch.cc (right):
https://codereview.chromium.org/422063005/diff/70001/src/hydrogen-bch.cc#newcode179
src/hydrogen-bch.cc:179: #pragma GCC diagnostic ignored
"-Wuninitialized"
Remove this, GCC 4.4 is unsupported.
https://codereview.chromium.org/422063005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
