https://codereview.chromium.org/522873002/diff/20001/src/compiler/common-operator.h
File src/compiler/common-operator.h (right):
https://codereview.chromium.org/522873002/diff/20001/src/compiler/common-operator.h#newcode50
src/compiler/common-operator.h:50: PUSH_OUTPUT, // Push the output on
the expression stack.
Nit: Can we use kPushOutput and kIgnoreOutput here? I kinda prefer to
use capitalized naming for #define's only, at least in new code.
https://codereview.chromium.org/522873002/diff/20001/src/compiler/operator-properties-inl.h
File src/compiler/operator-properties-inl.h (right):
https://codereview.chromium.org/522873002/diff/20001/src/compiler/operator-properties-inl.h#newcode175
src/compiler/operator-properties-inl.h:175: // inline bool
OperatorProperties::CanLazilyDeoptimize(Operator* op) {
Why is this still here?
https://codereview.chromium.org/522873002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
