LGTM.
https://codereview.chromium.org/523593002/diff/1/src/compiler/graph-visualizer.cc
File src/compiler/graph-visualizer.cc (right):
https://codereview.chromium.org/523593002/diff/1/src/compiler/graph-visualizer.cc#newcode213
src/compiler/graph-visualizer.cc:213: <<
(NodeProperties::IsControlEdge(edge) ? "style=dashed" : "")
suggestion: As discussed offline, it might make sense to flip the styles
of control-edges and context-edges. To me the most important edges are
the control-edges most of the time, so intuitively it makes sense to me
to have them be bold.
https://codereview.chromium.org/523593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
