Revision: 23557
Author: [email protected]
Date: Mon Sep 1 11:17:39 2014 UTC
Log: Fix assertion in JSLoadContext typer.
[email protected]
Review URL: https://codereview.chromium.org/531533003
https://code.google.com/p/v8/source/detail?r=23557
Modified:
/branches/bleeding_edge/src/compiler/typer.cc
=======================================
--- /branches/bleeding_edge/src/compiler/typer.cc Tue Aug 19 04:54:06 2014
UTC
+++ /branches/bleeding_edge/src/compiler/typer.cc Mon Sep 1 11:17:39 2014
UTC
@@ -493,8 +493,10 @@
Bounds Typer::Visitor::TypeJSLoadContext(Node* node) {
Bounds outer = OperandType(node, 0);
- DCHECK(outer.upper->Is(Type::Internal()));
- DCHECK(outer.lower->Equals(outer.upper));
+ DCHECK(outer.upper->Maybe(Type::Internal()));
+ // TODO(rossberg): More precisely, instead of the above assertion, we
should
+ // back-propagate the constraint that it has to be a subtype of Internal.
+
ContextAccess access = OpParameter<ContextAccess>(node);
Type* context_type = outer.upper;
MaybeHandle<Context> context;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
