Revision: 2807 Author: [email protected] Date: Wed Sep 2 00:34:51 2009 Log: RegExp: Remove unnecessary function from ARM specific code and convert condition to assertion.
Review URL: http://codereview.chromium.org/178034 http://code.google.com/p/v8/source/detail?r=2807 Modified: /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.cc /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.h /branches/bleeding_edge/src/jsregexp.cc ======================================= --- /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.cc Mon Aug 31 05:40:37 2009 +++ /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.cc Wed Sep 2 00:34:51 2009 @@ -130,15 +130,6 @@ int RegExpMacroAssemblerARM::stack_limit_slack() { return RegExpStack::kStackLimitSlack; } - - -bool RegExpMacroAssemblerARM::CanReadUnaligned() { -#if V8_TARGET_CAN_READ_UNALIGNED - return true; -#else - return false; -#endif -} void RegExpMacroAssemblerARM::AdvanceCurrentPosition(int by) { ======================================= --- /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.h Mon Aug 31 05:40:37 2009 +++ /branches/bleeding_edge/src/arm/regexp-macro-assembler-arm.h Wed Sep 2 00:34:51 2009 @@ -45,7 +45,6 @@ RegExpMacroAssemblerARM(Mode mode, int registers_to_save); virtual ~RegExpMacroAssemblerARM(); virtual int stack_limit_slack(); - virtual bool CanReadUnaligned(); virtual void AdvanceCurrentPosition(int by); virtual void AdvanceRegister(int reg, int by); virtual void Backtrack(); ======================================= --- /branches/bleeding_edge/src/jsregexp.cc Mon Aug 31 05:40:37 2009 +++ /branches/bleeding_edge/src/jsregexp.cc Wed Sep 2 00:34:51 2009 @@ -1723,8 +1723,8 @@ GetQuickCheckDetails(details, compiler, 0, trace->at_start() == Trace::FALSE); if (details->cannot_match()) return false; if (!details->Rationalize(compiler->ascii())) return false; - if (details->characters() > 1 && - !compiler->macro_assembler()->CanReadUnaligned()) return false; + ASSERT(details->characters() == 1 || + compiler->macro_assembler()->CanReadUnaligned()); uint32_t mask = details->mask(); uint32_t value = details->value(); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
