[v8-dev] MIPS: InterfaceDescriptor becomes CallInterfaceDescriptor. (issue 530783003 by [email protected])

Mon, 01 Sep 2014 10:05:14 -0700

Reviewers: danno, mvstanton, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec, dusmil.imgtec, 

Description:
MIPS: InterfaceDescriptor becomes CallInterfaceDescriptor.

Port r23560 (9a63ff6)

Original commit message:
There was no difference between these two classes in a hierarchical
relationship.

BUG=

Please review this at https://codereview.chromium.org/530783003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+16, -18 lines):
  M src/mips/interface-descriptors-mips.cc
  M src/mips/lithium-mips.h
  M src/mips/lithium-mips.cc
  M src/mips64/interface-descriptors-mips64.cc
  M src/mips64/lithium-mips64.h
  M src/mips64/lithium-mips64.cc


Index: src/mips/interface-descriptors-mips.cc
diff --git a/src/mips/interface-descriptors-mips.cc b/src/mips/interface-descriptors-mips.cc index 3bbc583973bad948f3fcfcd0b19ecb0c59bc5383..5dfa93ed9fbee3e8a00903cb6628a5239a425b92 100644 
--- a/src/mips/interface-descriptors-mips.cc
+++ b/src/mips/interface-descriptors-mips.cc
@@ -11,7 +11,7 @@
 namespace v8 {
 namespace internal {

-const Register InterfaceDescriptor::ContextRegister() { return cp; }
+const Register CallInterfaceDescriptor::ContextRegister() { return cp; }


 void CallDescriptors::InitializeForIsolate(Isolate* isolate) {
Index: src/mips/lithium-mips.cc
diff --git a/src/mips/lithium-mips.cc b/src/mips/lithium-mips.cc
index 7b4223da1f2cb69f4f6f6b59379682d2f50ce3ee..9f302e730b1e20a474ab0a90488f9c3438f2cd70 100644 
--- a/src/mips/lithium-mips.cc
+++ b/src/mips/lithium-mips.cc
@@ -1087,7 +1087,7 @@ LInstruction* LChunkBuilder::DoCallJSFunction(

 LInstruction* LChunkBuilder::DoCallWithDescriptor(
     HCallWithDescriptor* instr) {
-  const InterfaceDescriptor* descriptor = instr->descriptor();
+  const CallInterfaceDescriptor* descriptor = instr->descriptor();

   LOperand* target = UseRegisterOrConstantAtStart(instr->target());
   ZoneList<LOperand*> ops(instr->OperandCount(), zone());
Index: src/mips/lithium-mips.h
diff --git a/src/mips/lithium-mips.h b/src/mips/lithium-mips.h
index 1fefe237b55dad9652ddfc159bdfb63750495265..cbaba546924a080c5852b40a0c5634b2bb304b9a 100644 
--- a/src/mips/lithium-mips.h
+++ b/src/mips/lithium-mips.h
@@ -1837,18 +1837,17 @@ class LCallJSFunction V8_FINAL : public LTemplateInstruction<1, 1, 0> { 

 class LCallWithDescriptor V8_FINAL : public LTemplateResultInstruction<1> {
  public:
-  LCallWithDescriptor(const InterfaceDescriptor* descriptor,
-                      const ZoneList<LOperand*>& operands,
-                      Zone* zone)
-    : descriptor_(descriptor),
-      inputs_(descriptor->GetRegisterParameterCount() + 1, zone) {
+  LCallWithDescriptor(const CallInterfaceDescriptor* descriptor,
+                      const ZoneList<LOperand*>& operands, Zone* zone)
+      : descriptor_(descriptor),
+        inputs_(descriptor->GetRegisterParameterCount() + 1, zone) {
DCHECK(descriptor->GetRegisterParameterCount() + 1 == operands.length()); 
     inputs_.AddAll(operands, zone);
   }

   LOperand* target() const { return inputs_[0]; }

-  const InterfaceDescriptor* descriptor() { return descriptor_; }
+  const CallInterfaceDescriptor* descriptor() { return descriptor_; }

  private:
   DECLARE_CONCRETE_INSTRUCTION(CallWithDescriptor, "call-with-descriptor")
@@ -1858,7 +1857,7 @@ class LCallWithDescriptor V8_FINAL : public LTemplateResultInstruction<1> { 

   int arity() const { return hydrogen()->argument_count() - 1; }

-  const InterfaceDescriptor* descriptor_;
+  const CallInterfaceDescriptor* descriptor_;
   ZoneList<LOperand*> inputs_;

   // Iterator support.
Index: src/mips64/interface-descriptors-mips64.cc
diff --git a/src/mips64/interface-descriptors-mips64.cc b/src/mips64/interface-descriptors-mips64.cc index ee4cfb88694a37930045a94dd95a05948cb34b8b..fe2d71806a4ac32f0ab143f441a7b5c1ccb16201 100644 
--- a/src/mips64/interface-descriptors-mips64.cc
+++ b/src/mips64/interface-descriptors-mips64.cc
@@ -11,7 +11,7 @@
 namespace v8 {
 namespace internal {

-const Register InterfaceDescriptor::ContextRegister() { return cp; }
+const Register CallInterfaceDescriptor::ContextRegister() { return cp; }


 void CallDescriptors::InitializeForIsolate(Isolate* isolate) {
Index: src/mips64/lithium-mips64.cc
diff --git a/src/mips64/lithium-mips64.cc b/src/mips64/lithium-mips64.cc
index 8670cdff86194a29d7423f09d136e94e2efe910b..97c196164e687e694697b337e0eb3854a50cf3ea 100644 
--- a/src/mips64/lithium-mips64.cc
+++ b/src/mips64/lithium-mips64.cc
@@ -1087,7 +1087,7 @@ LInstruction* LChunkBuilder::DoCallJSFunction(

 LInstruction* LChunkBuilder::DoCallWithDescriptor(
     HCallWithDescriptor* instr) {
-  const InterfaceDescriptor* descriptor = instr->descriptor();
+  const CallInterfaceDescriptor* descriptor = instr->descriptor();

   LOperand* target = UseRegisterOrConstantAtStart(instr->target());
   ZoneList<LOperand*> ops(instr->OperandCount(), zone());
Index: src/mips64/lithium-mips64.h
diff --git a/src/mips64/lithium-mips64.h b/src/mips64/lithium-mips64.h
index 77e5b9c38dc66b772e3ac5eca98488a52dd25a93..0aae3f3f760358bfc4217e7de00e726991a60ce1 100644 
--- a/src/mips64/lithium-mips64.h
+++ b/src/mips64/lithium-mips64.h
@@ -1836,18 +1836,17 @@ class LCallJSFunction V8_FINAL : public LTemplateInstruction<1, 1, 0> { 

 class LCallWithDescriptor V8_FINAL : public LTemplateResultInstruction<1> {
  public:
-  LCallWithDescriptor(const InterfaceDescriptor* descriptor,
-                      const ZoneList<LOperand*>& operands,
-                      Zone* zone)
-    : descriptor_(descriptor),
-      inputs_(descriptor->GetRegisterParameterCount() + 1, zone) {
+  LCallWithDescriptor(const CallInterfaceDescriptor* descriptor,
+                      const ZoneList<LOperand*>& operands, Zone* zone)
+      : descriptor_(descriptor),
+        inputs_(descriptor->GetRegisterParameterCount() + 1, zone) {
DCHECK(descriptor->GetRegisterParameterCount() + 1 == operands.length()); 
     inputs_.AddAll(operands, zone);
   }

   LOperand* target() const { return inputs_[0]; }

-  const InterfaceDescriptor* descriptor() { return descriptor_; }
+  const CallInterfaceDescriptor* descriptor() { return descriptor_; }

  private:
   DECLARE_CONCRETE_INSTRUCTION(CallWithDescriptor, "call-with-descriptor")
@@ -1857,7 +1856,7 @@ class LCallWithDescriptor V8_FINAL : public LTemplateResultInstruction<1> { 

   int arity() const { return hydrogen()->argument_count() - 1; }

-  const InterfaceDescriptor* descriptor_;
+  const CallInterfaceDescriptor* descriptor_;
   ZoneList<LOperand*> inputs_;

   // Iterator support.


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to