LGTM.
https://codereview.chromium.org/529893002/diff/1/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/529893002/diff/1/src/compiler/simplified-lowering.cc#newcode257
src/compiler/simplified-lowering.cc:257: int values =
OperatorProperties::GetValueInputCount(node->op());
nit: Can we move the values into the condition (i.e. one line below).
Having it be decremented to zero in two exclusive conditions looks
dangerous to me.
https://codereview.chromium.org/529893002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
