Thanks for review!
https://codereview.chromium.org/527763002/diff/20001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/527763002/diff/20001/src/parser.h#newcode603
src/parser.h:603: Parser(CompilationInfo* info, uintptr_t stack_limit,
uint32_t hash_seed,
On 2014/09/02 08:47:40, rossberg wrote:
Would it be worth introducing a struct to collect these additional
arguments?
E.g. ParseInfo or something?
Ok. Ultimately, we'd want is separate structs for things which are
inputs to the parse phase and for things which are outputs from the
parse phase. That would clarify things. Currently CompilationInfo has
both...
Anyhow, I added ParserInfo here, to store these three things. Parser
doesn't need to store, because it only passes the information forward.
(I moved the AstValueFactory creation to Parser ctor, so we don't need
to store the hash seed any more. That would've been the right place for
the code anyway.)
ParserInfo is passed the same way as CompilationInfo, i.e., the caller
creates it on the stack and passes a pointer (ownership not
transferred).
https://codereview.chromium.org/527763002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
