Reviewers: Michael Starzinger,
Message:
As reported offline.
Description:
Fix bug in graph visualizer.
[email protected]
Please review this at https://codereview.chromium.org/526373002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -7 lines):
M src/compiler/graph-visualizer.cc
Index: src/compiler/graph-visualizer.cc
diff --git a/src/compiler/graph-visualizer.cc
b/src/compiler/graph-visualizer.cc
index
0edc0d3d5cbe614d1e3f9d87759d795ca8e0540e..10d6698a2cbeacde0be30471d1db346c30ea8c16
100644
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -209,14 +209,14 @@ void GraphVisualizer::PrintEdge(Node::Edge edge) {
(OperatorProperties::GetControlInputCount(from->op()) > 0 &&
NodeProperties::GetControlInput(from) != to)) {
os_ << ":I" << index << ":n -> ID" << to->id() << ":s"
- << "[" << (unconstrained ? "constraint=false" : "")
- << (NodeProperties::IsControlEdge(edge) ? "style=bold" : "")
- << (NodeProperties::IsEffectEdge(edge) ? "style=dotted" : "")
- << (NodeProperties::IsContextEdge(edge) ? "style=dashed" : "")
<< "]";
+ << "[" << (unconstrained ? "constraint=false, " : "")
+ << (NodeProperties::IsControlEdge(edge) ? "style=bold, " : "")
+ << (NodeProperties::IsEffectEdge(edge) ? "style=dotted, " : "")
+ << (NodeProperties::IsContextEdge(edge) ? "style=dashed, " : "")
<< "]";
} else {
- os_ << " -> ID" << to->id() << ":s [color=transparent"
- << (unconstrained ? ", constraint=false" : "")
- << (NodeProperties::IsControlEdge(edge) ? ", style=dashed" : "")
<< "]";
+ os_ << " -> ID" << to->id() << ":s [color=transparent, "
+ << (unconstrained ? "constraint=false, " : "")
+ << (NodeProperties::IsControlEdge(edge) ? "style=dashed, " : "")
<< "]";
}
os_ << "\n";
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
