Reviewers: adamk ooo until sept8, Dmitry Lomov (chromium), marja, rossberg,
Message:
I might be slow to post another patch set. This week is going to be a bit
crazy
for me.
https://codereview.chromium.org/477263002/diff/160001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/477263002/diff/160001/src/ast.h#newcode2493
src/ast.h:2493: class IsArrow : public BitField<bool, 6, 1> {};
On 2014/08/25 09:39:29, rossberg wrote:
Please don't define overlapping bitfields. In particular, these ones
silently
break when somebody changes the values in the definition of
FunctionKind.
Yes, it does have a tight coupling but it leads to more concise and more
efficient code.
What would be your suggestion? To remove IsArrow, IsGenerator and
IsConciseMethod and then do another masking as needed?
https://codereview.chromium.org/477263002/diff/160001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/477263002/diff/160001/src/preparser.h#newcode1873
src/preparser.h:1873: typename ParserBase<Traits>::IdentifierT
ParserBase<Traits>::ParsePropertyName(
On 2014/08/25 09:39:30, rossberg wrote:
Nit: Given that it's called only in one place, I don't think this
wrapper is
necessary.
This was done done for readability. The out params are don't care and
since it was being called from a context where we have is_getter and
is_setter it got confusing.
https://codereview.chromium.org/477263002/diff/160001/src/preparser.h#newcode1897
src/preparser.h:1897: checker->CheckProperty(next, kValueProperty,
On 2014/08/25 09:39:30, rossberg wrote:
Can this check be factored out and moved after the if-chain, to avoid
its
duplication?
I had that at first but the call to CheckProperty depends on the current
state of the parser/scanner. I can try to refactor further.
Description:
ES6: Add support for method shorthand in object literals
This is governed by the harmony-object-literals flag.
BUG=v8:3516
LOG=Y
Please review this at https://codereview.chromium.org/477263002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+602, -304 lines):
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm64/full-codegen-arm64.cc
M src/arm64/lithium-codegen-arm64.cc
M src/ast.h
M src/code-stubs.h
M src/code-stubs.cc
M src/code-stubs-hydrogen.cc
M src/compiler.cc
M src/contexts.h
M src/factory.h
M src/factory.cc
M src/flag-definitions.h
M src/full-codegen.cc
M src/globals.h
M src/hydrogen-instructions.h
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/mips/full-codegen-mips.cc
M src/mips/lithium-codegen-mips.cc
M src/mips64/full-codegen-mips64.cc
M src/mips64/lithium-codegen-mips64.cc
M src/objects.h
M src/objects-inl.h
M src/parser.h
M src/parser.cc
M src/preparser.h
M src/preparser.cc
M src/runtime.h
M src/runtime.cc
M src/v8natives.js
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M src/x87/full-codegen-x87.cc
M src/x87/lithium-codegen-x87.cc
M test/cctest/test-parsing.cc
A test/mjsunit/harmony/object-literals-method.js
A + test/mjsunit/runtime-gen/functionisconcisemethod.js
M tools/generate-runtime-tests.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
