LGTM, with comment.

http://codereview.chromium.org/171114/diff/1/2
File src/platform-macos.cc (right):

http://codereview.chromium.org/171114/diff/1/2#newcode212
Line 212: const mach_header* header = _dyld_get_image_header(i);
Could you move this variable into the #ifdef instead?  Is there a
get_header that returns a 64-bit header pointer?

http://codereview.chromium.org/171114

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to