https://codereview.chromium.org/522723002/diff/1/test/mjsunit/es6/math-hyperbolic.js
File test/mjsunit/es6/math-hyperbolic.js (right):
https://codereview.chromium.org/522723002/diff/1/test/mjsunit/es6/math-hyperbolic.js#newcode111
test/mjsunit/es6/math-hyperbolic.js:111:
assertEqualsDelta(74.209948524787, Math.cosh(-5), 1E-12);
On 2014/09/01 09:35:42, Yang wrote:
On 2014/08/29 16:23:31, Raymond Toy wrote:
> Is there any reason to keep the tests in 108-111? If yes, then you
should
> probably use the correct values and test for equality: cosh(0.5) =
> 1.1276259652063807d0, and cosh(5) = 74.20994852478785d0
>
> The same goes for the sinh tests in lines 105-106: sinh(5) =
74.20321057778875d0
>
> If you want some further tests, you could use the properties cosh(x)
+ sinh(x)
=
> exp(x) and cosh(x)^2-sinh(x)^2 = 1.
I corrected those test expectations. I think we are fine regarding
tests so far.
Actually I was hoping that we would eventually get some coverage in
Test262 once
we have formal specification on accuracy.
I was assuming you'd change the assertEqualsDelta to assertEquals, since
there's no delta required now. Oh well.
https://codereview.chromium.org/522723002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
