Reviewers: Christian Plesner Hansen, Description: Add verification flags to debug mjsunit test runs.
Please review this at http://codereview.chromium.org/186006 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/testcfg.py M test/mjsunit/testcfg.py Index: test/cctest/testcfg.py =================================================================== --- test/cctest/testcfg.py (revision 2809) +++ test/cctest/testcfg.py (working copy) @@ -31,7 +31,7 @@ import platform import utils -DEBUG_FLAGS = ['--enable-slow-asserts', '--debug-code', '--verify-heap'] +CCTEST_DEBUG_FLAGS = ['--enable-slow-asserts', '--debug-code', '--verify-heap'] class CcTestCase(test.TestCase): @@ -55,7 +55,7 @@ serialization_option = '--testing_serialization_file=' + serialization_file result = [ self.executable, name, serialization_option ] if self.mode == 'debug': - result += DEBUG_FLAGS + result += CCTEST_DEBUG_FLAGS return result def GetCommand(self): Index: test/mjsunit/testcfg.py =================================================================== --- test/mjsunit/testcfg.py (revision 2809) +++ test/mjsunit/testcfg.py (working copy) @@ -31,7 +31,7 @@ import re import tempfile - +MJSUNIT_DEBUG_FLAGS = ['--enable-slow-asserts', '--debug-code', '--verify-heap'] FLAGS_PATTERN = re.compile(r"//\s+Flags:(.*)") FILES_PATTERN = re.compile(r"//\s+Files:(.*)") SELF_SCRIPT_PATTERN = re.compile(r"//\s+Env: TEST_FILE_NAME") @@ -58,6 +58,8 @@ flags_match = FLAGS_PATTERN.search(source) if flags_match: result += flags_match.group(1).strip().split() + if self.mode == 'debug': + result += MJSUNIT_DEBUG_FLAGS additional_files = [] files_match = FILES_PATTERN.search(source); # Accept several lines of 'Files:' --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
