On 2014/09/02 at 15:12:55, titzer wrote:
On 2014/09/01 10:26:56, Benedikt Meurer wrote:
> Committed patchset #1 (id:1) manually as 23551 (presubmit successful).
NOT LGTM
This was *not* agreed upon and I very strongly disagree putting these test
here. Please move it back.
Argh, both me and Jochen asked a few weeks ago, and at least from what I
got,
Michi was the last one complaining. And besides that the whole team decided
several times that we will follow the Google/Chromium Coding Style, and the
Chromium Coding Style (http://www.chromium.org/developers/coding-style) is
pretty clear about it: "Unit tests and performance tests should be placed
in the
same directory as the functionality they're testing." (in
section "Naming"). So,
either we *DO FOLLOW* the coding style or we *DON'T FOLLOW* it; feel free to
bring up the discussion with our tech lead again, but no half-baked "let's
pick
rule 1, 3 and 5, but not 2 and 4", that doesn't scale and just lead to these
stupid discussions every now and then!
https://codereview.chromium.org/530693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
