Reviewers: jochen,
Message:
Jochen: PTAL
Thiago: FYI
Description:
Add missing -Wno-missing-field-initializer flag to standalone.gypi.
Chrome uses -Wno-missing-field-initializers when building V8, so we
should better use that as well. It silences warnings generated for the
GTest port files.
BUG=v8:3518
LOG=n
Please review this at https://codereview.chromium.org/535283006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+23, -5 lines):
M build/standalone.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
57617a3a81fba13dec376ac70e78f2f920921109..b09122b538e33b27ada26fac414cf007656c8e7d
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -215,9 +215,18 @@
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
or OS=="netbsd"', {
'target_defaults': {
- 'cflags': [ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
- '-Wno-long-long', '-pthread', '-fno-exceptions',
- '-pedantic' ],
+ 'cflags': [
+ '-Wall',
+ '<(werror)',
+ '-W',
+ '-Wno-unused-parameter',
+ '-Wno-long-long',
+ '-pthread',
+ '-fno-exceptions',
+ '-pedantic',
+ # Don't warn about the "struct foo f = {0};" initialization
pattern.
+ '-Wno-missing-field-initializers',
+ ],
'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
'ldflags': [ '-pthread', ],
'conditions': [
@@ -234,8 +243,15 @@
# or OS=="netbsd"'
['OS=="qnx"', {
'target_defaults': {
- 'cflags': [ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
- '-fno-exceptions' ],
+ 'cflags': [
+ '-Wall',
+ '<(werror)',
+ '-W',
+ '-Wno-unused-parameter',
+ '-fno-exceptions',
+ # Don't warn about the "struct foo f = {0};" initialization
pattern.
+ '-Wno-missing-field-initializers',
+ ],
'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
'conditions': [
[ 'visibility=="hidden"', {
@@ -361,6 +377,8 @@
'-Wendif-labels',
'-W',
'-Wno-unused-parameter',
+ # Don't warn about the "struct foo f = {0};" initialization
pattern.
+ '-Wno-missing-field-initializers',
],
},
'conditions': [
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
