On 2014/09/02 21:12:27, aperez wrote:
On 2014/08/11 08:51:39, marja wrote:> https://codereview.chromium.org/422923004/diff/20001/src/ast-value-factory.h> File src/ast-value-factory.h (right): > >
https://codereview.chromium.org/422923004/diff/20001/src/ast-value-factory.h#newcode91
> src/ast-value-factory.h:91: bool IsArguments() const { return
> IsOneByteEqualTo("arguments"); }
> This doesn't look correct. The AstStrings are unique, so you should be
able
to
> compare the AstString* to AstValueFactory::arguments_string(). >> Is the problem that where this is used, there's no AstValueFactory? If so,that > should probably be fixed... I mean, surely the AstValueFactory is
*somewhere*
> since we managed to create the AstString...
I have updated the CL, the new version picks the value returned by of "Parser::ast_value_factory()->arguments_string()" to make the pointer comparison. For PreParser, the flag is checked directly from the bits int "PreParserIdentifier" and the AstValueFactory is unused.
Okay, that part LG. The code for "is this string arguments" slightly obscure but I think the obscurity is only because the PreParser doesn't create AstStrings
and Parser does, so working around this will make the code slightly awkward. https://codereview.chromium.org/422923004/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
