Reviewers: jarin,
Message:
PTAL
Description:
Add cwd to all shell commands in auto roll scripts.
The v8 root directory is assumed to be the default cwd. All
commands executed in another directory (e.g. the chromium
checkout) need an explicit specification (also in the
tests).
This also fixes several small testing and robustness bugs:
- Get rid of all 'rm ...' shell calls
- Don't leak tmp files/dirs
- Add some forgotten shell calls to the test expectations
- Hardcode the DEPS location (must always be
chromium_dir/DEPS)
- Expect correct return code when terminating gracefully
BUG=chromium:408523
LOG=n
[email protected]
TEST=script_test.py
Please review this at https://codereview.chromium.org/540973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+266, -233 lines):
M tools/push-to-trunk/chromium_roll.py
M tools/push-to-trunk/common_includes.py
M tools/push-to-trunk/git_recipes.py
M tools/push-to-trunk/push_to_trunk.py
M tools/push-to-trunk/releases.py
M tools/push-to-trunk/test_scripts.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
