After the fact comments that should be addressed. -Ivan
http://codereview.chromium.org/191004/diff/1/2 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/191004/diff/1/2#newcode276 Line 276: for (int i = 0; i <= 15; i++) { Please use named constants here. http://codereview.chromium.org/191004/diff/1/2#newcode278 Line 278: if (i <= 10) { and here. http://codereview.chromium.org/191004/diff/1/2#newcode281 Line 281: PrintF("%s: 08x%x %d\n", reg_names[15 + 16 - i], value, value); and here. Better yet, abstract the register to name mapping from the disassembler into constants_arm.h and constants_arm.cc and use it here and in the disassembler. http://codereview.chromium.org/191004/diff/1/2#newcode301 Line 301: USE(obj); This USE can be dropped now, that obj is used in DEBUG and non-DEBUG builds. http://codereview.chromium.org/191004 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
