Reviewers: jarin,
Description:
Platform-dependent turbofan tests.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/541343003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+16, -13 lines):
M test/cctest/compiler/codegen-tester.cc
M test/cctest/compiler/test-simplified-lowering.cc
Index: test/cctest/compiler/codegen-tester.cc
diff --git a/test/cctest/compiler/codegen-tester.cc
b/test/cctest/compiler/codegen-tester.cc
index
8a7b902741fd6ba92ffb14d12b93aea55956bc1d..b1874f552650cbcb98f6cf427f925ae842829e10
100644
--- a/test/cctest/compiler/codegen-tester.cc
+++ b/test/cctest/compiler/codegen-tester.cc
@@ -369,6 +369,8 @@ void Int32BinopInputShapeTester::RunRight(
}
+#if V8_TURBOFAN_TARGET
+
TEST(ParametersEqual) {
RawMachineAssemblerTester<int32_t> m(kMachInt32, kMachInt32);
Node* p1 = m.Parameter(1);
@@ -380,8 +382,6 @@ TEST(ParametersEqual) {
}
-#if V8_TURBOFAN_TARGET
-
void RunSmiConstant(int32_t v) {
// TODO(dcarney): on x64 Smis are generated with the SmiConstantRegister
#if !V8_TARGET_ARCH_X64
Index: test/cctest/compiler/test-simplified-lowering.cc
diff --git a/test/cctest/compiler/test-simplified-lowering.cc
b/test/cctest/compiler/test-simplified-lowering.cc
index
6627807bf4467835ec9f9386a68067e35e92710a..de0caae707a4da1c8976dc27fda945f1bf55e7db
100644
--- a/test/cctest/compiler/test-simplified-lowering.cc
+++ b/test/cctest/compiler/test-simplified-lowering.cc
@@ -1054,17 +1054,20 @@ TEST(LowerReferenceEqual_to_wordeq) {
TEST(LowerStringOps_to_call_and_compare) {
- TestingGraph t(Type::String(), Type::String());
- IrOpcode::Value compare_eq =
- static_cast<IrOpcode::Value>(t.machine()->WordEqual()->opcode());
- IrOpcode::Value compare_lt =
- static_cast<IrOpcode::Value>(t.machine()->IntLessThan()->opcode());
- IrOpcode::Value compare_le =
-
static_cast<IrOpcode::Value>(t.machine()->IntLessThanOrEqual()->opcode());
- t.CheckLoweringBinop(compare_eq, t.simplified()->StringEqual());
- t.CheckLoweringBinop(compare_lt, t.simplified()->StringLessThan());
- t.CheckLoweringBinop(compare_le,
t.simplified()->StringLessThanOrEqual());
- t.CheckLoweringBinop(IrOpcode::kCall, t.simplified()->StringAdd());
+ if (Pipeline::SupportedTarget()) {
+ // These tests need linkage for the calls.
+ TestingGraph t(Type::String(), Type::String());
+ IrOpcode::Value compare_eq =
+ static_cast<IrOpcode::Value>(t.machine()->WordEqual()->opcode());
+ IrOpcode::Value compare_lt =
+ static_cast<IrOpcode::Value>(t.machine()->IntLessThan()->opcode());
+ IrOpcode::Value compare_le = static_cast<IrOpcode::Value>(
+ t.machine()->IntLessThanOrEqual()->opcode());
+ t.CheckLoweringBinop(compare_eq, t.simplified()->StringEqual());
+ t.CheckLoweringBinop(compare_lt, t.simplified()->StringLessThan());
+ t.CheckLoweringBinop(compare_le,
t.simplified()->StringLessThanOrEqual());
+ t.CheckLoweringBinop(IrOpcode::kCall, t.simplified()->StringAdd());
+ }
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
