Reviewers: Benedikt Meurer,
Description:
Fix another assertion in the context typer.
[email protected]
Please review this at https://codereview.chromium.org/540283002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -2 lines):
M src/compiler/typer.cc
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index
6edfda329cec3d8391d981b66a36aebb7cd7bff3..e898eb323dd508ab587208fcd25252cdd3e4ceb6
100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -95,8 +95,9 @@ class Typer::Visitor : public NullNodeVisitor {
Type* ContextType(Node* node) {
Bounds result =
NodeProperties::GetBounds(NodeProperties::GetContextInput(node));
- DCHECK(result.upper->Is(Type::Internal()));
- DCHECK(result.lower->Equals(result.upper));
+ DCHECK(result.upper->Maybe(Type::Internal()));
+ // TODO(rossberg): More precisely, instead of the above assertion, we
should
+ // back-propagate the constraint that it has to be a subtype of
Internal.
return result.upper;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
