LGTM
http://codereview.chromium.org/171115/diff/6001/7002 File src/v8threads.cc (right): http://codereview.chromium.org/171115/diff/6001/7002#newcode244 Line 244: int ThreadManager::last_id_ = 0; Please add a comment about that a thread cannot have id 0. http://codereview.chromium.org/171115/diff/6001/7002#newcode331 Line 331: int thread_id = ++last_id_; Maybe assert thread_id > 0. http://codereview.chromium.org/171115 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
