2009/9/4 Matthew Wilson <[email protected]>:
> Well, that's not correct either. (for example, ð is output as ð) Also..
That looks correct. It's UTF-8 coded Unicode.
> write("\u000a") actually writes (on my machine - Windows) CRLF
> ("\u000d\u000a")....
This one is debatable.
For the Mandelbrot app we would need some sort of binary stream. I'm
not sure whether strings should be output as little endian 16 bit
values, 16 bit big endian values or 8 bit values (discarding the top
halves of each character).
>
> On Fri, Sep 4, 2009 at 11:05 AM, <[email protected]> wrote:
>>
>> Reviewers: Christian Plesner Hansen,
>>
>> Description:
>> Fixing presubmit error
>>
>> [email protected]
>>
>> Please review this at http://codereview.chromium.org/192024
>>
>> Affected files:
>> M src/d8.cc
>>
>>
>> Index: src/d8.cc
>> diff --git a/src/d8.cc b/src/d8.cc
>> index
>>
>> 7133b7ad2aa1abc99103b281634debae7fd3d979..ce48dc9ff180d971a46a13748d4985ebe5f48d48
>> 100644
>> --- a/src/d8.cc
>> +++ b/src/d8.cc
>> @@ -159,7 +159,7 @@ Handle<Value> Shell::Write(const Arguments& args) {
>> printf(" ");
>> }
>> v8::String::Utf8Value str(args[i]);
>> - fwrite(*str, sizeof(char), str.length(), stdout);
>> + fwrite(*str, sizeof(**str), str.length(), stdout);
>> }
>> return Undefined();
>> }
>>
>>
>>
>>
>
>
> >
>
--
Erik Corry, Software Engineer
Google Denmark ApS. CVR nr. 28 86 69 84
c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018
Copenhagen K, Denmark.
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
