https://codereview.chromium.org/555833002/diff/20001/src/base/bits.h
File src/base/bits.h (right):
https://codereview.chromium.org/555833002/diff/20001/src/base/bits.h#newcode128
src/base/bits.h:128: return (((res ^ lhs) & (res ^ rhs)) >> 31) & 1;
On 2014/09/09 13:10:48, Sven Panne wrote:
I think that
return (((res ^ lhs) & (res ^ rhs) & (1U << 31)) != 0;
is a bit clearer and involves no implicit conversion, similar below.
Done.
https://codereview.chromium.org/555833002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
