Reviewers: rossberg,
Description:
Some follow-up fixes after r23801.
[email protected]
TEST=mjsunit --turbo-types
Please review this at https://codereview.chromium.org/559563002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -5 lines):
M src/compiler/js-operator.h
M src/compiler/typer.cc
Index: src/compiler/js-operator.h
diff --git a/src/compiler/js-operator.h b/src/compiler/js-operator.h
index
f2d039e29ea959b9576030217d568bbe61b87a79..cb3c47c73588d1caadc46846036beb8aee9e76e0
100644
--- a/src/compiler/js-operator.h
+++ b/src/compiler/js-operator.h
@@ -156,7 +156,7 @@ class JSOperatorBuilder {
}
Operator* StoreContext(uint16_t depth, uint32_t index) {
ContextAccess access(depth, index, false);
- OP1(JSStoreContext, ContextAccess, access, Operator::kNoProperties, 2,
1);
+ OP1(JSStoreContext, ContextAccess, access, Operator::kNoProperties, 2,
0);
}
Operator* TypeOf() { SIMPLE(JSTypeOf, Operator::kPure, 1, 1); }
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index
3b56265ea41c4837c30a7cc02a72e1285cb5c71e..da66a82cf4e16fd74572d6dbb9ab9dc86d9ba882
100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -303,14 +303,13 @@ Bounds Typer::Visitor::TypeFinish(Node* node) {
Bounds Typer::Visitor::TypeFrameState(Node* node) {
- UNREACHABLE();
- return Bounds();
+ // TODO(rossberg): Ideally FrameState wouldn't have a value output.
+ return Bounds(Type::Internal(zone()));
}
Bounds Typer::Visitor::TypeStateValues(Node* node) {
- UNREACHABLE();
- return Bounds();
+ return Bounds(Type::Internal(zone()));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
