On 2014/09/09 12:33:32, caitp wrote:
On 2014/09/09 12:14:18, Diego Pino wrote:
> On 2014/09/09 10:59:36, aperez wrote:
> > https://codereview.chromium.org/553623004/diff/1/src/runtime.cc
> > File src/runtime.cc (right):
> >
> >
https://codereview.chromium.org/553623004/diff/1/src/runtime.cc#newcode6130
> > src/runtime.cc:6130: RUNTIME_FUNCTION(Runtime_ToLength) {
> > Is there any particular reason not to implement this in JS? The CL for
> > "Array.from" has one version that looks okay:
> > https://codereview.chromium.org/363833006/diff/290001/src/runtime.js
> >
> > That being said, I think it is better to have separate, smaller CL
like
this
> to
> > introduce a ToLength() function. Once this is merged, then the CL for
> > "Array.from" can be made simpler, too.
>
> No particular reason for implementing it as a runtime function. Since
ToLength()
> is already coded, and reviewed, as part of the Array.from() CL, I think
the
> JavaScript implementation is the way to go. So, caitp could you create a
> separate CL for implementing ToLength()? WDYT?
sure, I'll put something up in an hour or 2
Thanks. For future reference, https://codereview.chromium.org/552273002/
https://codereview.chromium.org/553623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
