Comment #3 on issue 433 by [email protected]: 64-bit V8 crashes on P4
machines
http://code.google.com/p/v8/issues/detail?id=433
> void MacroAssembler::FCmp() {
> fcompp();
> push(rax);
> fnstsw_ax();
> if (CpuFeatures::IsSupported(CpuFeatures::SAHF)) {
> sahf();
> } else {
> shrl(rax, Immediate(8));
> and_(rax, Immediate(0xFF));
> push(rax);
> popfq();
> }
> pop(rax);
> }
I already opened Issue #376 about using fcomi in V8, which would be a
better fix for
this issue than this code. It is available in all P6 and later CPUs,
including all
64-bit CPUs, and the lack of lahf/sahf on early Intel x64 is a good reason
to use it.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
