Reviewers: Michael Starzinger,
Message:
Committed patchset #1 (id:1) manually as 23826 (presubmit successful).
Description:
Allow externalizing cons and sliced string.
Fulfill overdue TODO.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=23058
Committed: https://code.google.com/p/v8/source/detail?r=23826
Please review this at https://codereview.chromium.org/460643002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -5 lines):
M src/api.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
7098859de3cfa9fa85d786b29cf8eef56846f086..8dbe0a1c10c2c20f6dda26a895f13c8faa04227f
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -5541,11 +5541,6 @@ bool v8::String::CanMakeExternal() {
i::Handle<i::String> obj = Utils::OpenHandle(this);
i::Isolate* isolate = obj->GetIsolate();
- // TODO(yangguo): Externalizing sliced/cons strings allocates.
- // This rule can be removed when all code that can
- // trigger an access check is handlified and therefore GC safe.
- if (isolate->heap()->old_pointer_space()->Contains(*obj)) return false;
-
if (isolate->string_tracker()->IsFreshUnusedString(obj)) return false;
int size = obj->Size(); // Byte size of the original string.
if (size < i::ExternalString::kShortSize) return false;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
