Revision: 23826
Author: [email protected]
Date: Wed Sep 10 08:47:16 2014 UTC
Log: Allow externalizing cons and sliced string.
Fulfill overdue TODO.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=23058
Review URL: https://codereview.chromium.org/460643002
https://code.google.com/p/v8/source/detail?r=23826
Modified:
/branches/bleeding_edge/src/api.cc
=======================================
--- /branches/bleeding_edge/src/api.cc Mon Sep 8 04:44:22 2014 UTC
+++ /branches/bleeding_edge/src/api.cc Wed Sep 10 08:47:16 2014 UTC
@@ -5566,11 +5566,6 @@
i::Handle<i::String> obj = Utils::OpenHandle(this);
i::Isolate* isolate = obj->GetIsolate();
- // TODO(yangguo): Externalizing sliced/cons strings allocates.
- // This rule can be removed when all code that can
- // trigger an access check is handlified and therefore GC safe.
- if (isolate->heap()->old_pointer_space()->Contains(*obj)) return false;
-
if (isolate->string_tracker()->IsFreshUnusedString(obj)) return false;
int size = obj->Size(); // Byte size of the original string.
if (size < i::ExternalString::kShortSize) return false;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
