Reviewers: Yang, refack,
Message:
On 2014/09/10 at 09:44:58, refack wrote:
On 2014/08/26 09:20:07, Benedikt Meurer wrote:
> Committed patchset #1 manually as 23389 (presubmit successful).
Any Idea why I still can't build this on Ubuntu 14 x64 (GCC 4.8.8 / GCC
4.9.1
/ Clang 3.5.1)?
something failing about instantiating the template
What is this "something" that is failing? Maybe you can file a bug report
with
detailed error messages.
Description:
Replace our homegrown ARRAY_SIZE() with Chrome's arraysize().
Our own ARRAY_SIZE() was pretty bad at error checking. If you use
arrasize() in a wrong way, the compiler will issue an error instead of
silently doing the wrong thing. The previous ARRAY_SIZE() macro is still
available as ARRAYSIZE_UNSAFE() similar to Chrome.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=23389
Please review this at https://codereview.chromium.org/501323002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+592, -531 lines):
M src/api.cc
M src/arm/code-stubs-arm.cc
M src/arm64/assembler-arm64.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/instrument-arm64.cc
M src/arm64/simulator-arm64.cc
M src/ast.cc
M src/base/logging.cc
M src/base/macros.h
M src/bootstrapper.cc
M src/cached-powers.cc
M src/code-stubs.cc
M src/compiler/arm/instruction-selector-arm.cc
M src/compiler/arm64/instruction-selector-arm64.cc
M src/compiler/graph.h
M src/compiler/graph-builder.h
M src/compiler/ia32/instruction-selector-ia32.cc
M src/compiler/instruction-selector.cc
M src/compiler/js-generic-lowering.cc
M src/compiler/x64/instruction-selector-x64.cc
M src/conversions.cc
M src/debug.cc
M src/deoptimizer.h
M src/execution.cc
M src/factory.cc
M src/full-codegen.cc
M src/global-handles.cc
M src/heap/heap.cc
M src/hydrogen.cc
M src/ia32/code-stubs-ia32.cc
M src/isolate.cc
M src/jsregexp.cc
M src/lithium-codegen.cc
M src/messages.cc
M src/mips/code-stubs-mips.cc
M src/mips64/code-stubs-mips64.cc
M src/mksnapshot.cc
M src/objects.cc
M src/parser.cc
M src/runtime.cc
M src/serialize.cc
M src/strtod.cc
M src/types.cc
M src/vector.h
M src/x64/code-stubs-x64.cc
M src/x87/code-stubs-x87.cc
M test/base-unittests/platform/platform-unittest.cc
M test/cctest/compiler/call-tester.h
M test/cctest/compiler/test-branch-combine.cc
M test/cctest/compiler/test-instruction.cc
M test/cctest/compiler/test-js-constant-cache.cc
M test/cctest/compiler/test-js-typed-lowering.cc
M test/cctest/compiler/test-node-cache.cc
M test/cctest/compiler/test-phi-reducer.cc
M test/cctest/compiler/test-representation-change.cc
M test/cctest/compiler/test-run-machops.cc
M test/cctest/compiler/test-simplified-lowering.cc
M test/cctest/compiler/test-structured-ifbuilder-fuzzer.cc
M test/cctest/compiler/test-structured-machine-assembler.cc
M test/cctest/compiler/value-helper.h
M test/cctest/test-api.cc
M test/cctest/test-checks.cc
M test/cctest/test-compiler.cc
M test/cctest/test-cpu-profiler.cc
M test/cctest/test-date.cc
M test/cctest/test-debug.cc
M test/cctest/test-heap-profiler.cc
M test/cctest/test-mark-compact.cc
M test/cctest/test-object-observe.cc
M test/cctest/test-parsing.cc
M test/cctest/test-random-number-generator.cc
M testing/gtest-support.h
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
