The yurys's comments were addressed. About adding column information to the
hit
count map - I or someone from Weiliang team can it as a separate patch.
https://codereview.chromium.org/424973004/diff/200001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://codereview.chromium.org/424973004/diff/200001/src/profile-generator.cc#newcode688
src/profile-generator.cc:688: if (src_line_not_found && *entry) {
On 2014/09/10 08:05:14, yurys wrote:
With this approach we may end up with top entry being pc_entry while
src_line
will be calculated for another entry which is wrong. We should also
check here
that current entry is the first one non-null in the path.
pc_offset that used to calculate src_line is taken for the first
non-null entry in the path only. Exactly this entry will represent a
node in profile (when the path and src_line go to
AddPathToCurrentProfiles).
https://codereview.chromium.org/424973004/diff/200001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/424973004/diff/200001/test/cctest/test-cpu-profiler.cc#newcode1099
test/cctest/test-cpu-profiler.cc:1099: if
(func->code()->is_optimized_code()) {
On 2014/09/10 08:05:14, yurys wrote:
You can use "%NeverOptimizeFunction(func)" or
%OptimizeFunctionOnNextCall to
make this more deterministic.
The test should check optimized code also. I suggest to stay as is
because to test both optimized and non-optimized version of function.
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
